search

runatlantis / helm-charts

Atlantis Helm Chart
Apache License 2.0
115 stars 186 forks source link

Unable to use custom port #420

Open doctahpopp opened 2 months ago

doctahpopp commented 2 months ago

You have the ability to set the targetPort and portName on the service definition, as well as the ability to define ATLANTIS_PORT env variable on the statefulSet to use a custom port with this workload.

However, this does not update the port on container spec or the readinessProbes.

These sections use static blocks https://github.com/runatlantis/helm-charts/blob/main/charts/atlantis/templates/statefulset.yaml#L238-L240 https://github.com/runatlantis/helm-charts/blob/main/charts/atlantis/templates/statefulset.yaml#L505-L521

Propose updating the chart to use service.targetPort to configure all of the necessary port settings on the chart resources.

Ill cut an MR.

doctahpopp commented 1 month ago

@GMartinez-Sisti Have a look at the MR let me know we might be able to get it merged!