Provide the ability to deploy Atlantis without a domain associated to it

runatlantis / terraform-gce-atlantis

A set of Terraform configurations for running Atlantis on @googlecloud Compute Engine

Apache License 2.0

31 stars 20 forks source link

Provide the ability to deploy Atlantis without a domain associated to it #100

Open JSNortal opened 1 year ago

JSNortal commented 1 year ago

It would be useful to make the domain input optional to and allow for the module to either reserve a static external IP or take as an input.

It would make getting up and running a bit faster for testing purposes.

bschaatsbergen commented 1 year ago

@JSNortal thanks for taking the time to raise this issue 👍🏼 What are your thoughts on this? @kpocius

kpocius commented 1 year ago

Sounds doable, although I'd keep the reservation out of the scope of the module, much like it is now done with DNS records. Also, this needs to come with proper warnings that some potential security features will be lost (e.g. I don't see this setup working with IAP).

steliossid commented 6 months ago

Is it possible to use a reserved external static IP in GCP as the domain?