runbox / runbox7

Runbox 7 web app
Other
125 stars 24 forks source link

TinyMCE in HTML mode intercepts right-click options #480

Open runboxdave opened 4 years ago

runboxdave commented 4 years ago

TinyMCE in HTML mode seems to intercept right-click actions which prevent the normal operation of the OS and prevent the user accessing the options that would normally be available in a text window.

Is this desirable behaviour given that the only right-click option presented by TinyMCE is to make something a link?

tadzik commented 4 years ago

Here's what I found out (with help from documentation).

By default, the contextmenu only has the link option in it. We can add more options or we can disable the contextmenu completely. If the contextmenu is enabled user can Ctrl+rightclick to bring up the browser context menu. If it's disabled, ctrl+rightclick doesn't "toggle it back" though.

I'd be in favour of just disabling it completely since links can be created just as easily without it. Alternatively we can add another option to the TinyMCE menu that says "use ctrl+click for the regular context menu". And then we have to worry about how that works on a Mac... ;)

I'd be in favour of just disabling it completely:

diff --git a/src/app/rmm/plugin/tinymce.plugin.ts b/src/app/rmm/plugin/tinymce.plugin.ts
index c040217..c163137 100644
--- a/src/app/rmm/plugin/tinymce.plugin.ts
+++ b/src/app/rmm/plugin/tinymce.plugin.ts
@@ -55,6 +55,7 @@ export class TinyMCEPlugin {
                             {text: 'C#', value: 'csharp'},
                             {text: 'C++', value: 'cpp'}
                         ]),
+                contextmenu: false,
                 image_list: (options.image_list || []),
                 menubar: (options.menubar || false),
                 setup: (options.setup),
gtandersen commented 4 years ago

@tadzik @davidbowdley We can disable it if it does not cause problems with future upgrades.

gtandersen commented 3 years ago

@davidbowdley This appears to have been solved via #622 -- or is it still occurring?