search

runceel / plantumlpreview

MIT License
15 stars 6 forks source link

[New Feature] Support for reStructuredText file types #17

Closed tomigaprv closed 7 years ago

tomigaprv commented 7 years ago

Apart from plain text it would be nice to have support for reSturcturedText which is used for writing documentation in Sphinx.

I want to use your plugin together with following extension available under following link https://marketplace.visualstudio.com/items?itemName=lextudio.restructuredtext

and here GitHub project https://github.com/vscode-restructuredtext/vscode-restructuredtext

runceel commented 7 years ago

Thank you for your feedback.

But, I think that PlantUML don't support reStructuredText.

tomigaprv commented 7 years ago

My idea was to use your plugin together with reStructuredText plugin so I just wanted that you add in your plugin support for additional file type apart from "plain text". Somewhere in createPlantumlSnippet function just extend the condition

if (!(editor.document.languageId === 'plaintext')) { return this.errorSnippet("not plaintext"); }

In reStructuredText mode currently I will have just "not plaintext" message. After change I was expecting that I will able to see just pure text + generated UML diagrams... (it is enough for me)

Does my assumption is correct?

Concerning not supporting "uml" by reStructuredText I am using Sphinx environment which can handle both restructuredText with "embeded" uml diagrams.

runceel commented 7 years ago

I added restructuredtext support. Please try use with reSturcturedText.

tomigaprv commented 7 years ago

Greate! Thanks a lot. I will try on Monday and provide feedback to you.

tomigaprv commented 7 years ago

ok, restructuredText files are not blocked now but I still cannot get previou because of "Unable to open 'PlantUML Preview': write EPIPE" :(. At least thanks for this change.