runceel / plantumlpreview

MIT License
15 stars 6 forks source link

Doesn't work on Windows 10 #3

Closed mastoj closed 7 years ago

mastoj commented 7 years ago

I can't get the plugin to run on my windows 10 machine. I have set the PLANTUML_HOME, JAVA_HOME and TEMP env. variables, but I still get a message that I haven't done so. Also, it complains that the command 'extension.exportPlantUML' is not found, but I guess that is a error caused by the first problem.

Anything I can do to get debugging info?

runceel commented 7 years ago

I tested Windows 10 AU machines and Windows 7 machine. Did you rebooted VS Code after have set env?

Tyank you.

mastoj commented 7 years ago

Yes. Tried restart code without success. Does it matter which profile you set the variables on? I mean, machine or personal profile.

Want be able to try it again until next week, but if you know something I could try I do it then.

An alternative solution for you might be that one can override those settings in the configuration of the extension.

On Fri, Sep 2, 2016, 16:51 Kazuki Oota notifications@github.com wrote:

I tested Windows 10 AU machines and Windows 7 machine.

Did you rebooted VS Code after have set env?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/runceel/plantumlpreview/issues/3#issuecomment-244396990, or mute the thread https://github.com/notifications/unsubscribe-auth/AAemsHiVJtS2vpo9XstqFrDv0PsRNIytks5qmDfpgaJpZM4Jzvhv .

runceel commented 7 years ago

This check logic is very simple.

    if (!process.env['PLANTUML_HOME'] || !process.env['JAVA_HOME'] || !process.env['TEMP']) {
        vscode.window.showErrorMessage('Setup enviroment variable. PLANTUML_HOME, JAVA_HOME, TEMP'); 
        return;
    }

I set personal pfofile.(sorry it is japanese language.)

default

Can you execute plantuml that command?

"%JAVA_HOME%\bin\java.exe" -jar "%PLANTUML_HOME%\plantuml.jar"
mastoj commented 7 years ago

I can't try until next week.

Maybe you can add a message that tells the user which variable that is missing?

On Fri, Sep 2, 2016, 17:03 Kazuki Oota notifications@github.com wrote:

This check logic is very simple.

if (!process.env['PLANTUML_HOME'] || !process.env['JAVA_HOME'] || !process.env['TEMP']) {
    vscode.window.showErrorMessage('Setup enviroment variable. PLANTUML_HOME, JAVA_HOME, TEMP');
    return;
}

I set personal pfofile.(sorry it is japanese language.)

[image: default] https://cloud.githubusercontent.com/assets/79868/18208166/4889a6d8-7169-11e6-8f4c-c4a87a3b762c.PNG

Can you execute plantuml that command?

"%JAVA_HOME%\bin\java.exe" -jar "%PLANTUML_HOME%\plantuml.jar"

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/runceel/plantumlpreview/issues/3#issuecomment-244400244, or mute the thread https://github.com/notifications/unsubscribe-auth/AAemsDUdKWyZesflbbWsijm3aRwPirCHks5qmDqLgaJpZM4Jzvhv .

runceel commented 7 years ago

I released v0.0.6. Error message improvement.

Separate error message to env value.

if (!process.env['PLANTUML_HOME'] || !process.env['JAVA_HOME'] || !process.env['TEMP']) {
    if (!process.env['PLANTUML_HOME']) { vscode.window.showErrorMessage('Set enviroment variable. PLANTUML_HOME.'); } 
    if (!process.env['JAVA_HOME']) { vscode.window.showErrorMessage('Set enviroment variable. JAVA_HOME.'); } 
    if (!process.env['TEMP']) { vscode.window.showErrorMessage('Set enviroment variable. TEMP.'); } 
    return;
}
runceel commented 7 years ago

What is a status?

mastoj commented 7 years ago

I tried it now and it works fine after update! Really nice!

runceel commented 7 years ago

Thenk you!!