search

runcitadel / dashboard

Other
11 stars 5 forks source link

Skip app check for ringtools #32

Closed AaronDewes closed 2 years ago

AaronDewes commented 2 years ago

Even with the CORS fix, the app was still shown as "starting". So this will work as a temporary workaround for 0.0.5

pwltr commented 2 years ago

The same logic should be added to AppStoreApp.vue that also contains the polling. A fallback idea to work around this CORS issue would be to work with the manager to check for container status with something like docker container inspect -f '{{.State.Status}}' ringtools-main-1. It's not as good an end-to-end check as the current HTTP request polling but it would work around the CORS/CORP issues. It also might come in handy for apps that don't have a web UI.

pwltr commented 2 years ago

We should also add some screenshots for this app.

AaronDewes commented 2 years ago

Sure, they can be added later. Will update the AppStoreApp code though.