search

rundeck-plugins / jira-notification

Add job status information as a comment to a JIRA issue
24 stars 16 forks source link

Plugin should support loading the password from Rundeck's Key Storage #19

Open marcjay opened 4 years ago

marcjay commented 4 years ago

Currently we need to place the password/token in plain-text in the project configuration. It would be good if instead, we could supply the path to a key in Key Storage, e.g.

project.plugin.Notification.JIRA.password=keys/jira-api-token

for the plugin to then fetch the value of the key from storage

It's not clear if this project is still active - if it is and a PR for this would be accepted, I'd happily take a look at implementing this.

marcjay commented 4 years ago

After attempting this and running into issues, I now understand from the rundeck-discuss Google Group that this is not possible - it's an intentional limitation of Notification plugins for security: https://groups.google.com/g/rundeck-discuss/c/d4f8FeLG7j0/m/nFZ6-jBYCQAJ

marcjay commented 4 years ago

This is now possible since the release of 3.3.4 which contains https://github.com/rundeck/rundeck/pull/6457

barra51 commented 3 years ago

Hi @marcjay are you still planning on implement this? We can work on this if you are interested

marcjay commented 3 years ago

Hi @marcjay are you still planning on implement this? We can work on this if you are interested

Hi @barra51 I've actually already implemented this, and some other improvements on a private fork. I've attempted to get a PR into this repo (#20) but had difficulty trying to get it reviewed and merged, so I've not had much incentive to submit more PRs until I see proof this repo is still active

barra51 commented 3 years ago

Nice! I think it will be difficult to have it merged, since this repo doesn't have updates from a long time ago. It would be great to have your changes merged into this plugin, would be greatly appreciated and is a must to have some encryption for this kind of stuff! @marcjay

marcjay commented 3 years ago

@barra51 you encouraged me to put a PR out for those changes 😄 - if you want to use the changes rather than wait for the PR to possibly get merged, you can either copy the changes in #21 or check out my load-password-from-key-storage branch in https://github.com/marcjay/jira-notification (commit: a2297a7638067453665784f228fcb438d41da5a4). Let me know if you hit any issues

barra51 commented 3 years ago

@marcjay You rock man!! thank you so much! I just built your changes and everything worked like a charm!! Hope that this changes will be merged soon

Thanks again!!

marcjay commented 3 years ago

Great to hear! 😄