rundeck-plugins / kubernetes

52 stars 59 forks source link

possibly incorrect indents in create_volume() in common.py #107

Closed kdebisschop closed 2 years ago

kdebisschop commented 3 years ago

The indents in the current code do not correspond to the python k8s API and make the code subject to failure if type is not specified in the YAML. But I think the data maps to https://github.com/kubernetes-client/python/blob/master/kubernetes/docs/V1HostPathVolumeSource.md whihc says type is optional.

On that basis, I think volume.host_paath should be set whether or not a type is specified and the code should not fail if a type is unspecified.