rundeck-plugins / kubernetes

52 stars 59 forks source link

Reuse connection params from resource model in executor #56

Closed aliksend closed 3 years ago

aliksend commented 4 years ago

Store kubernetes settings in node params and then read it in common.py

55

kdebisschop commented 3 years ago

This basic approach is working for me -- it would be lovely to reduce this patch down to the changes in pods-resource-model.py and common.py that are the functional changes and get that integrated. It's a critical feature IMO, I cannot live with the idea of repeating the same auth info in literally hundreds of node steps that run our current infrastructure.

kdebisschop commented 3 years ago

@ltamaster would you accept an alternate pull request that did not have file conflicts and did not remove the script args?

ltamaster commented 3 years ago

@kdebisschop that is ok for me

kdebisschop commented 3 years ago

@ltamaster Excellent!

See #99