search

rundeck-plugins / rundeck-ec2-nodes-plugin

Get resource node data from Amazon EC2
86 stars 45 forks source link

Plugin does not provide a way to concatenate EC2 attributes #24

Closed pkr1234 closed 7 years ago

pkr1234 commented 9 years ago

Rundeck only displays the nodename in "matched nodes" of the job. So it is important that the nodename contains all the relevant information to identify a node when running a job.

The default for this plugin is: nodename.selector=tags/Name,instanceId

There are two problems with this:

  1. tags/Name will not be unique in autoscaled instances since the tags are propagated.
  2. It uses instanceId only when tags/Name is missing

Therefore, we need a way to make nodename unique which can be done by concatenating the two items - tags/Name + instanceId. Is this possible?

gschueler commented 9 years ago

you are right, this was brought up in #10, it's a good feature to add

maybe using + char to indicate concatenation

pkr1234 commented 9 years ago

Thanks Greg,

Please could you let me know when this feature is likely to be implemented?

gschueler commented 9 years ago

hi @pkr1234 i don't know, sorry :(

ghost commented 9 years ago

this would be extremely useful.

aguy commented 8 years ago

+1 I came here looking exactly how to do this.

gschueler commented 7 years ago

implemented in https://github.com/rundeck-plugins/rundeck-ec2-nodes-plugin/pull/58