search

rundeck-plugins / rundeck-s3-log-plugin

Store execution logs in Amazon S3 buckets
Apache License 2.0
32 stars 26 forks source link

Allow custom endpoints to be used #11

Closed jamieps closed 8 years ago

jamieps commented 8 years ago

Allow the endpoint to be customised, so that a local S3-compatible storage cluster can be used. If a custom endpoint is used, the region setting is ignored, fixes #10.

Currently, when using a custom endpoint Signature Version 4 is enforced.

gschueler commented 8 years ago

is the "Signature Version 4" a requirement? or just for your local S3-compatible storage service?

jamieps commented 8 years ago

It can be optional, depending on whether the storage service supports v4. I included it as it's recommended in the Skylable documentation.

If you'd prefer I can make that optional?

gschueler commented 8 years ago

@jamieps sure, i think that would be better. does it have to be a global setting?

jamieps commented 8 years ago

@gschueler I can't see any other way of doing it, unfortunately. I'll make the setting available regardless of whether the endpoint is custom, in case it's useful elsewhere.

gschueler commented 8 years ago

@jamieps sounds good

jamieps commented 8 years ago

@gschueler thanks, I've added a new property to control that separately