search

rundeck-plugins / rundeck-s3-log-plugin

Store execution logs in Amazon S3 buckets
Apache License 2.0
32 stars 23 forks source link

Add possibility to use Signature V2 for old AWS S3-compatible #26

Closed navya35 closed 5 years ago

navya35 commented 5 years ago

I tested the plugin with our Rundeck and we always had the error The request signature we calculated does not match the signature you provided. Check your key and signing method.. It was linked with the signature of plugin that use V4 instead of V2, even if the boolean forceSigV4 was equal to false. After a lot of search on Internet, it is necessary to force the signer to V2 and send the configuration to Amazon S3 Client. I added a boolean to indicate exactly which signature version use.

navya35 commented 5 years ago

@gschueler I created this pull request

navya35 commented 5 years ago

@gschueler if it is ok for you, perhaps it will be a good idea to apply it on rundeckpro-s3-logstorage plugin

navya35 commented 5 years ago

@gschueler any news on this pull request ?

gschueler commented 5 years ago

@navya35 i will review as soon as possible, thank you for the PR