search

rundeck-plugins / salt-step

Rundeck Salt Plugin
BSD 3-Clause "New" or "Revised" License
31 stars 30 forks source link

Rundeck timing out even if job is finished #14

Closed tehsu closed 5 years ago

tehsu commented 8 years ago

I'm trying to figure out what to add to fix this issue to the returners, I figured the default ones would cover this but doesn't look like it, I added state.sls to the configuration and recompiled the jar.

[salt.state ][INFO ] {'pid': 7435, 'retcode': 0, 'stderr': '', 'stdout': '.'}

Would this parser work here?

defaultCommandParser: &defaultCommandParser !!org.rundeck.plugin.salt.output.SaltJsonReturnHandler {exitCodeKey: retcode, standardOutputKey: stdout, standardErrorKey: stderr}

petrudumuta commented 8 years ago

Hey @tehsu ! Did you manage to get it working when using the state.sls function?

tehsu commented 8 years ago

I did, I had to use the fork from here, https://github.com/apenvern/salt-step

I compiled it with some changes to the defaultReturners.yml, but it works perfectly now. I can provide the changes that I made.

petrudumuta commented 8 years ago

Cool! Yes, if you could provide them that would be great. Thanks!

tehsu commented 8 years ago

All you need to change is the defaultReturners.yaml, it has state.highstate: *alwaysSuccessful, copy it and change it to state.sls

petrudumuta commented 8 years ago

yeah, just tested and it works, thought it was something more involved :) thanks for your quick reply! almost lost a day on this :(

tehsu commented 8 years ago

better than me, I lost a week

tehsu commented 5 years ago

This needs to be merged, https://github.com/rundeck-plugins/salt-step/pull/19. It's the correct fix. Closing my ticket.