search

rundeck-plugins / ui-job-graph

Displays DAG of Jobs based on Job References.
6 stars 7 forks source link

replace .success() with .done() due to JS deprecation. Fixes UI dash load error. #8

Open akh13 opened 1 year ago

akh13 commented 1 year ago

Apologies for the duplicate PR. This seems to fix a dashboard load error that prevents the javascript from running properly. Without it, I receive this in the console:

Uncaught TypeError: loader.load(...).success is not a function loadNextJob https://rundeck.testsite.com/plugin/file/UI/ui-job-graph/js/jobgraph.js:755 loadJobListData https://rundeck.testsite.com/plugin/file/UI/ui-job-graph/js/jobgraph.js:763 loadJobsListPage https://rundeck.testsite.com/plugin/file/UI/ui-job-graph/js/jobgraph.js:459

To fix this, the method has to be changed as below, because there is .success() in these locations. Can someone please verify if this fix works?

benbugohit commented 1 year ago

thanks ! it works on 4.11

snyrkill commented 1 year ago

Thank you. This now works in 4.9, 4.10 and 4.11 :) This also fixes the ui-job-list plugin.

ptrybowski commented 5 months ago

Are there plans to merge this PR? Is the plugin even supported at this point?