Don't throw if unknown properties are encountered in .mml

springmeyer commented 13 years ago

The MML syntax is evolving - basically as more map/render level properties are needed. Currently the carto parser errors out on unknown properties - ideally each of these properties could be collected and stored for later use (for now, after collecting them, they could be output in a warning after parsing).

For context see discussion at https://github.com/mapbox/tilelive-mapnik/issues/4

springmeyer commented 13 years ago

Great, I see the improvement now:

d:carto-parser dane$ ./carto-parser ~/Documents/MapBox/project/open-streets-dc/open-streets-dc.mml 
Error: Unknown keyword: bounds at Line: 7 Col: 3
Error: Unknown keyword: center at Line: 12 Col: 3
Error: Unknown keyword: format at Line: 13 Col: 17
Error: Unknown keyword: interactivity at Line: 14 Col: 24
Error: Unknown keyword: minzoom at Line: 15 Col: 14
Error: Unknown keyword: maxzoom at Line: 16 Col: 15
Error: Unknown keyword: class at Line: 102 Col: 3
Error: Unknown keyword: legend at Line: 103 Col: 476
Error: Unknown keyword: name at Line: 104 Col: 28
Error: Unknown keyword: description at Line: 105 Col: 57
Error: Unknown keyword: attribution at Line: 107 Col: 0
<?xml version="1.0" encoding="utf-8"?>
<Map srs="+proj=merc +a=6378137 +b=6378137 +lat_ts=0.0 +lon_0=0.0 +x_0=0.0 +y_0=0 +k=1.0 +units=m +nadgrids=@null +wktext +no_defs +over"/>

/cc @yhahn

springmeyer commented 13 years ago

wait: shouldn't those say "Warning:" ? as they do not appear to be fatal.

rundel commented 13 years ago

Current revision should give warnings and not errors

rundel / carto-parser

Don't throw if unknown properties are encountered in .mml #7