search

rundel / md4r

An R wrapper for the md4c markdown parsing library
https://rundel.github.io/md4r/
Other
4 stars 1 forks source link

Move towards code generation #7

Closed krlmlr closed 6 months ago

krlmlr commented 6 months ago

This is incomplete, but hopefully shows where we're heading. Still to do:

Does it work for you? Are you open to repeating this pattern for the three other tests?

krlmlr commented 6 months ago

@rundel: I'm done here for now, awaiting your review.

410a93b497a0b98dc3dfd1cec7d062454a707baf didn't add a test, should it have? If it did, it would show up as a diff after merging main and regenerating the test files.

krlmlr commented 6 months ago

Some last changes to make R CMD check happy, and to align with your code style. Done now.

Thanks for your prompt responses! Can't wait to use it in fledge! Are you open to releasing a patch update to CRAN?

krlmlr commented 6 months ago

Would you like to do the three other tests yourself, or do you need a hand?

rundel commented 6 months ago

Just taking a look at this now - looks like a great solution and I should be able to port the other 3 over easily. Thanks for the suggestion and the working example.