search

rundel / timezone

A small R package for finding timezone names from geographic coordinates
12 stars 2 forks source link

A duplication? #2

Open ateucher opened 6 years ago

ateucher commented 6 years ago

Hi @rundel it looks like I've inadvertently duplicated some of your work. See https://github.com/ateucher/lutz - for looking up timezones based on lat/long, or an sf or SpatialPoints[DataFrame] object (without requiring a web service).

The version of lutz currently on CRAN uses a javscript library in the backend - which is super fast but can be a little inaccurate close to borders. So I've implemented the same layer as @dfarnand is offering in PR #1 here. I've done some experimentation with simplifying it to a point that it is small enough to include in a CRAN package (< 5MB) but still accurate. You can see that testing here: https://github.com/ateucher/lutz/blob/master/scratch/test_timings.md. My plan is to have a really fast (but possibly slightly inaccurate) lookup using the javascript method, and a slower but very accurate method using the timezone map overlay method.

The thing that your package has that mine doesn't is the google api interface.

Anyway, I just wanted to touch base to see if we want to join forces, especially if you are planning to submit to CRAN?

martinctc commented 3 years ago

Have been looking for timezone solutions and found this post referencing to another package. Thank you!