search

rundfunk47 / stinsen

Coordinators in SwiftUI. Simple, powerful and elegant.
MIT License
822 stars 87 forks source link

Fixes compile-time error on Xcode 14 (example app) #75

Closed vascoorey closed 2 years ago

vascoorey commented 2 years ago

Need to add the Stinsen namespace due to naming clash with new NavigationStack on iOS 16

Screenshot 2022-06-18 at 07 12 33

abrown252 commented 2 years ago

Great catch on this.

Longer term I wonder if a naming prefix or a rename would be more appropriate, save having to fully qualify NavigationStack each time a navigation coordinator is created

rundfunk47 commented 1 year ago

Thanks for merging this. Yes, I agree @abrown252, perhaps a rename would be in order. Any suggestions?

abrown252 commented 1 year ago

That'a great question, I don't have an obvious replacement in mind.

Would it be appropriate to introduce a naming prefix here? STNavigationStack or something. The naming NavigationStack perfectly sums up the intension here, it would be a shame to move away from it completely