search

rundis / clj-light-refactor

Light Table plugin providing refactoring support for clojure
MIT License
55 stars 4 forks source link

Autoemplete not working #7

Open ShayMatasaro opened 9 years ago

ShayMatasaro commented 9 years ago

After installing the plugin auto complete for LT does not work any more

rundis commented 8 years ago

In any kind of editor or clojure editors ? (It disables textual hints by default, you can turn that back on as per the readme). Also bear in mind the autocomplete feature for clojure only kicks in if you have a connection to a clojure project for the editor in question.

MasterMastic commented 8 years ago

I have the same issue. @rundis for a connected Clojure editor it doesn't work. For the Clojure Instarepl editor it actually does work.I haven't tested other editors.

muhuk commented 8 years ago

I can confirm too:

With clj-light-refactor plugin installed: no autocomplete whatsoever. After uninstalling and restarting: normal LT autocomplete works.

Possibly because I don't have cider middleware? I think it still shouldn't stomp on the default autocomplete.

rundis commented 8 years ago

Yes you need to have Cider installed for it to work. Ideally I should have implemented something to check whether Cider was available in the classpath and only then turn on the behavior for the alternate autocomplete.

The readme explains how to turn off the auto completer from clj-light-refactor and turn the default clojure autocompleter back on: https://github.com/rundis/clj-light-refactor#91-a-better-autocomplete-

@ShayMatasaro @MasterMastic @muhuk

  1. So is anyone experiencing that with cider installed, do you still experience that the autocompleter doesn't work.
  2. Following the instructions to revert too the default behavior (as explained in the readme), do you still have problems ?

I could have made the new auto completer opt-in, but then I'm pretty sure very few would have found the info too turn it on (given that it appears the reporters here probably didn't notice the info about the cider requirement and the info for reverting back to the default behavior in LT).

The autocompleter feature in clj-light-refactor is way better in my opinion. Most of the nice features in clj-light-refactor depends on cider and refactor-nrepl middleware. Maybe I should split the plugin in 2, one for whatever doesn't require additional middleware and one that clearly does require them. I'll give it some consideration.

muhuk commented 8 years ago

I should have implemented something to check whether Cider was available in the classpath and only then turn on the behavior for the alternate autocomplete.

:thumbsup:

MasterMastic commented 8 years ago

@rundis I just now included refactor-nrepl "1.1.0" & cider/cider-nrepl "0.9.1. I had no idea they're needed for this, I think it should be bumped to the first sections in the README and that it shouldn't say they're just for "Middleware dependent refactorings" since that's outright misleading, isn't it?.

And yay! auto-complete now works! However reverting back to the default behavior disables the autocomplete entirely. So I'm personally satisfied but hit me up if I can help out. Thank you!