search

rundis / elm-bootstrap

Responsive and reliable web apps with Elm and Twitter Bootstrap
http://elm-bootstrap.info/
BSD 3-Clause "New" or "Revised" License
398 stars 72 forks source link

Add support for modal attributes #156

Closed Munksgaard closed 5 years ago

Munksgaard commented 5 years ago

Fixes #155

Munksgaard commented 5 years ago

Do you want it so that you can use multiple applications of Modal.attrs, or should each invocation just overwrite the previous one? In other words should values ++ options.attrs on line 289 instead by just values?

girishso commented 5 years ago

+1, I need this!

rundis commented 5 years ago

tx! and sorry for the (very) slow response

girishso commented 5 years ago

You forgot to publish the new package to elm-packages!

rundis commented 5 years ago

Patience is a virtue 😄 I'm fixing a few other things too. A new version will be released when I wrap up the batch of work I made (spare) time for doing work on this. Probably in the not to distant future.

girishso commented 5 years ago

Yep, just noticed the other commits, was about to delete my comment!

Thank you for your work on the package! :)