search

rundsk / dsk

DSK, short for “Design System Kit” – a workbench for collaboratively creating Design Systems
https://rundsk.com
Other
82 stars 8 forks source link

Filter Search never returns more than ten results #132

Closed ChristophLabacher closed 4 years ago

ChristophLabacher commented 4 years ago

When a node contains spaces in its title, filtering for tags does not work.

This pull request introduces tests to prove it and investigate the issue: https://github.com/rundsk/dsk/pull/131

ChristophLabacher commented 4 years ago

Figured out that my test where failing because I was expecting titles, not urls. 🙈

However I am still observing this issue in several production systems. Will keep investigating.

ChristophLabacher commented 4 years ago

I figured out that the title of the node has nothing to do with it, seems to have been coincidence.

Instead it appears the problem is that the filter search never returns more than ten results, even if there should be more. I added a test to show this.