VorpalBlade
commented
1 month ago Before I switched from log to tracing for my project I would get this when attempting to unwrap the returned result in my user code. I came up with this monstrosity as a workaround. But this doesn't help now that it crashes internally in tracing.
```rust
/// Attempt to format the error in the best way possible.
///
/// Unfortunately this is awkward with dynamic Rune values.
fn try_format_error(phase: Phase, e: &rune::Value) -> anyhow::Result<()> {
match e.clone().into_any() {
rune::runtime::VmResult::Ok(any) => {
match any.clone().downcast_into_ref::() {
Ok(err) => {
anyhow::bail!("Got error result from {phase}: {:?}", *err);
}
Err(err) => {
let ty = try_get_type_info(e, "error");
anyhow::bail!(
"Got error result from {phase}, but it was not an anyhow error: {err:?}, type info: {ty}: {any:?}",
);
}
}
}
rune::runtime::VmResult::Err(not_any) => {
tracing::error!("Got error result from {phase}, it was not an Any: {not_any:?}. Trying other approches at printing the error.");
}
}
// Attempt to format the error
let formatted = catch_unwind(AssertUnwindSafe(|| {
format!("Got error result from {phase}: {e:?}")
}));
match formatted {
Ok(str) => anyhow::bail!(str),
Err(_) => {
let ty = try_get_type_info(e, "error");
anyhow::bail!(
"Got error result from {phase}, but got a panic while attempting to format said error for printing, {ty}",
);
}
}
}
/// Best effort attempt at gettint the type info and printing it
fn try_get_type_info(e: &rune::Value, what: &str) -> String {
match e.type_info() {
rune::runtime::VmResult::Ok(ty) => format!("type info for {what}: {ty:?}"),
rune::runtime::VmResult::Err(err) => {
format!("failed getting type info for {what}: {err:?}")
}
}
}
```
udoprog
Given the following example code (full reproducer project attached as tar.gz below):
we get the following panic while running it:
Example project triggering this: rune_fmt_panic.tar.gz