runelite / launcher

Launcher for RuneLite
https://runelite.net
BSD 2-Clause "Simplified" License
65 stars 95 forks source link

Adjust Info.plist keys #105

Closed testing-ongithub closed 2 years ago

testing-ongithub commented 2 years ago

Since a launcher update seems imminent, here's a PR that can hopefully be included.

There are two changes, both to the Info.plist file:

Get Info menu before:

getinfo-before

Get Info menu after:

getinfo-after
Adam- commented 2 years ago
* LSRequiresNativeExecution is added. LSRequiresNativeExecution removes the ability for users to tell the m1 version to run using Rosetta. Since the m1 version doesn't work using Rosetta and attempting to run it like that prevents the app from starting, removing this option seems like a good idea.

  * edit: This also prevents the x86 version from running on an m1 mac, but I don't see why that would be desired behavior anyway with the m1 version available and seemingly issue-less.

With 897f1499a08b188a3f42eb2c9103cd287ddf9c3b we are dropping support of running the x64 launcher on m1 via Rosetta anyway so this sounds good