runelite / launcher

Launcher for RuneLite
https://runelite.net
BSD 2-Clause "Simplified" License
65 stars 95 forks source link

Wrap Desktop.Open() to fix buttons not working on Linux #77

Closed ghost closed 4 years ago

ghost commented 4 years ago

This should allow systems without GVFS to open the logs folder. This applies to the AppImage on none Gnome or bare bone systems, the raw Jar, and Snap.

ghost commented 4 years ago

After Abex's advice, the scope of this has extended to refactoring the LinkBrowser class, I've just been experimenting with the best way to approach that, having not done Java since uni it's taking a little while, but I'll have a much different commit coming up tomorrow.

As is now, this shouldn't be pulled.

ghost commented 4 years ago

The new LinkBrowser.open() wrapper for Desktop.open() should have the same effects but be better maintainability wise going forwards. If this looks good, it needs to be replicated in the client too as there's still functions that call Desktop.open() directly there.