Update style and increase resolution of macOS icons

[TylerADavis]

This PR Fixes #44 by increasing the resolution of icons on macOS from the original 128x128 maximum to up to 512x512@2x (1024x1024), resulting in much clearer icons in the Finder, dock, and in the quickswitcher. This PR also brings the icons in line with Apple's latest icon design guidelines for mac with the adoption of a new shape and a drop shadow. Some examples are shown below:

Previous highest resolution icon viewed through finder:

New equivalent icon:

New icon in dock, note uniform style:

[TylerADavis]

@devLotto Adam recommended I ask you to see how much this PR affects the size of the final DMG for distribution generated by build-osx.sh. The new .icns file is 1.9MB larger than the old one, and it's not clear how large an impact that would have within the compressed dmg.

I tried building the dmg myself, but I was getting 40-42 MB dmgs vs the 32 MB dmg file from runelite.net .

[alexanderhenne]

@TylerADavis For me using your icns file increases the DMG file size by 1.9MB. I don't do any special compressing other than what the code in build-osx.sh might do.

[TylerADavis]

@devLotto Thanks for taking a look! I'd guess that the 30 vs 40 MB disparity is due to either using a different version of macOS or a different version of some dependency.

I've tried to reduce the size of icons.icns by first passing the images through tinypng.com, but I didn't have any success. While tinypng.com successfully dropped the size of the raw PNGs, reducing the size of runelite.iconset from 2MB to 700KB, creating icons.icns using the command iconutil -c icns ./tiny_runelite.iconset resulted in the file size returning to 2MB (70 KB savings). I'm not very familiar with iconutil, but the documentation suggests that it should be compressing the images. Perhaps tinypng is using a compression format incompatible with icns or iconutil is automatically converting to a less efficient compression scheme.

@Adam- do you think the 2MB size increase is fine (+6% to download size, +1.2% to size of final launcher), or would you still prefer something smaller?

[alexanderhenne]

@TylerADavis We decided that +2MB is a large size increase just for icons and that it would be better if the 512 and 512@2x versions were removed (bringing the .icns file down to ~500KB).

[TylerADavis]

Hi @devLotto , thank you for your feedback. I've removed both the 512x512 and 512x512@2x assets, dropping the size of the .icns file from 2.1 MB to 535 KB. Please let me know if there are any other changes you'd like to see.

[mattthw]

I have been setting this manually. Would love to see it OOTB in an upcoming release if there are no further blockers to merging.

[TylerADavis]

@mmccoy37 This should be live in today's launcher release. I'm not sure if the patch/update process will automatically download the new icon, or if it would need to be reinstalled from scratch

[Adam-]

@mmccoy37 This should be live in today's launcher release. I'm not sure if the patch/update process will automatically download the new icon, or if it would need to be reinstalled from scratch

This would require manually installing the newer launcher.