search

runelite / runelite.net

RuneLite website
https://runelite.net
MIT License
78 stars 92 forks source link

fix RSS link #493

Closed kokarn closed 1 year ago

kokarn commented 1 year ago

It's failing because it's running the command build even tho I changed the command to be ci-build. I guess I could separate this into two PRs instead if that's a blocker

Nightfirecat commented 1 year ago

CI shouldn't be failing, so please add whatever changes are needed to ensure it passes.

kokarn commented 1 year ago

CI shouldn't be failing, so please add whatever changes are needed to ensure it passes.

Fair enough. Might do a PR after this then on how to run this on node 20 instead of the legacy stuff currently required :)

Nightfirecat commented 1 year ago

The RSS link seems to be working fine for me. What does this change fix?

kokarn commented 1 year ago

The RSS link seems to be working fine for me. What does this change fix?

So basically, because the news thing ~is infinite scroll~ lazy loads, I looked at the source to see if there was RSS, which gives you this image

This at least removes the localhost thing from it as that's definitely incorrect. Would also help non-js crawlers etc parse it

raiyni commented 1 year ago

What news thing? We don't have infinite scrolling anywhere. You should consider looking at the source on https://runelite.net/ not your localhost.

kokarn commented 1 year ago

What news thing? We don't have infinite scrolling anywhere. You should consider looking at the source on https://runelite.net/ not your localhost.

Yeah true, it's not infinite scroll. Was my mistake not having enough patience scrolling.

Also, I am looking at the source on the site image

Nightfirecat commented 1 year ago

It looks like you updated your master branch with a lot of other changes, so this PR isn't in a useful state anymore.

kokarn commented 1 year ago

It looks like you updated your master branch with a lot of other changes, so this PR isn't in a useful state anymore.

I've reverted all the changes I did in my upgrade branch that I accidentally merged to master 😓 . But do you want me to recreate the PR with just a single commit, is that what you're after here?

raiyni commented 1 year ago

We want you to revert your changes that are superfluous and only change the rss link.

Nightfirecat commented 1 year ago

I don't care too much what the commit history looks like, just get it back to the state it was in prior to 81194b6 (#493) and the rest being pushed

kokarn commented 1 year ago

Damn, I was more sloppy than I anticipated. New PR coming