runelite / runelite

Open source Old School RuneScape client
https://runelite.net
BSD 2-Clause "Simplified" License
4.76k stars 5.21k forks source link

Chat Notifications plugin Highlight words Wildcard #11524

Open Rikardos87 opened 4 years ago

Rikardos87 commented 4 years ago

Is your feature request related to a problem? Please describe. Can't use * for "Highlight words" wildcard in the Chat Notifications plugin, Similar to "NPCs to Highlight feature" in the NPC Indicators Plugin

Describe the solution you'd like Ability to use * for "Highlight words" wildcard in the Chat Notifications plugin, Similar to "NPCs to Highlight feature" in the NPC Indicators Plugin

Additional context Could not find that this had been suggested before, If it already have been suggested this request can be closed or removed.

bfmoatbio commented 4 years ago

NPC highlights must be complete matches, which makes the use of wildcards straightforward. Chat highlights can be partial matches, so the behavior of wildcards is not so straightforward. Perhaps their matching should be greedy only until the next whitespace? e.g.

Pattern: "duel*" Going to the duel arena soon Going dueling

Pattern: "duel *" Going to the duel arena soon Going dueling

Rikardos87 commented 4 years ago

That would be a good idea. As far as I can see at the moment if someone is saying a word that is on the list but it have additional letter the word won't be highlighted unless it matches 100% to the word you have added, which means you have to add several ending of the same word to the list. Would help if it really just detected the word you have set no matter the spelling. e.g.

Word: duel Going to the duel arena soon Going dueling Just dueled someone It's time to du-du-duel

It could just highlight the whole word like in bfmoatbio's example also, As long as the word you have in the list is present in the word.