runelite / runelite

Open source Old School RuneScape client
https://runelite.net
BSD 2-Clause "Simplified" License
4.81k stars 5.24k forks source link

buy limit reset timers duplicate themselves #11808

Closed 000000653 closed 4 years ago

000000653 commented 4 years ago

Describe the bug The buy limit reset timers duplicate every time you click any button in the grand exchange interface, guide price, enter quantity, and enter price buttons duplicate it once, any other button duplicates it twice.

It's also duplicated once upon opening the sell interface via clicking the item in your inventory instead of clicking the item after opening the sell interface.

This seems to only happen with items missing buy limits, items with known limits such as vial of water or brass key I cannot reproduce this with. Here's a list on the wiki. https://oldschool.runescape.wiki/w/Category:Exchange_items_missing_limit

To Reproduce

  1. Buy any item that doesn't have a buy limit. Some examples are Elven top, Blighted karambwan, Blighted manta ray, Dragonstone boots, etc.
  2. Either open the same item's buy interface or that item's sell interface.
  3. Click buttons.
  4. Observe dupe bugs.

Expected behaviour Should only set a timer when you actually buy an item.

Screenshots (gh doesn't support mp4 so youtube link it is) https://youtu.be/FX1N0YjrtgQ

Environment (please complete the following information):

Adam- commented 4 years ago

fixed in 3d762d7ca2f5cad30009f1d48dca5093155a8fc8