search

runelite / runelite

Open source Old School RuneScape client
https://runelite.net
BSD 2-Clause "Simplified" License
4.81k stars 5.24k forks source link

Mining Counter doesn't account for Varrock Platebody #12910

Open MattDiesel opened 3 years ago

MattDiesel commented 3 years ago

Mining plugin uses xptracker plugin to keep a count of actions, which doesn't equal ores when the varrock platebody special effect doubles the ore mined.

I suspect the same is true for the smelting effect of the platebody, but haven't tested that.

Could keep a second counter based on chat messages: "The Varrock platebody enabled you to mine an additional ore.". There would then need to be some maths to fix the Mined/hr amount, which could be done by getting the session time and adding the platebody additions per hour to the xptracker amount.

MattDiesel commented 3 years ago

I'm not a Java programmer, but will have a play at some point with getting the toolchain installed and see if I can get runelite running from source. If so, I'd be happy to do this and submit the pull request. It looks like the hook for getting chat messages is already there in the mining plugin so should be able to work it out.

MattDiesel commented 3 years ago

Can confirm, same thing happens with the smelting counter, and also the ring of forging counter.