search

runelite / runelite

Open source Old School RuneScape client
https://runelite.net
BSD 2-Clause "Simplified" License
4.83k stars 5.25k forks source link

Window position shifts 2,2 pixels when resizing on Tiling WM #14685

Closed Septem151 closed 2 years ago

Septem151 commented 2 years ago

Describe the bug On Tiling Window Managers (awesome-wm), the window position is not retained when resizing/redrawing by expanding the sidebar. The window will shift down 2 pixels and to the right 2 pixels each time the sidebar is opened or closed.

To Reproduce Steps to reproduce the behavior:

  1. Open RuneLite
  2. Open sidebar, see window shift
  3. Close sidebar, see window shift

Expected behavior Window should retain its X, Y position when resizing and redrawing.

Screenshots

https://imgur.com/WorBhA5

Environment (please complete the following information):

Additional context

client.log:

2022-02-11 02:01:19 [Preloader] INFO  net.runelite.client.rs.ClientLoader - Using cached vanilla client
2022-02-11 02:01:19 [Preloader] INFO  net.runelite.client.rs.ClientLoader - Using cached patched client
2022-02-11 02:01:19 [Preloader] INFO  net.runelite.client.rs.ClientLoader - client-patch 2072819879.40
2022-02-11 02:01:20 [main] INFO  n.r.c.plugins.kourendlibrary.Library - Library is now reset
2022-02-11 02:01:20 [main] INFO  n.r.c.e.ExternalPluginManager - Loading external plugin "virtual-level-ups" version "1.1.5" commit "95bafad4826edddb5f76eaf2f76c909405e3d4e8"
2022-02-11 02:01:20 [main] INFO  n.r.c.e.ExternalPluginManager - Loading external plugin "detached-camera" version "1.0" commit "50a0fc76749d041af23d6295959885824295b04f"
2022-02-11 02:01:20 [main] INFO  n.r.c.e.ExternalPluginManager - Loading external plugin "banked-experience" version "2.1.2" commit "a0a3bf4d7a462b3a9151ebb1241e7961eb15ceab"
2022-02-11 02:01:20 [main] INFO  n.r.c.e.ExternalPluginManager - Loading external plugin "117hd" version "1.0.13" commit "7c6f9909a929517c6994772963971c64b2f35f96"
2022-02-11 02:01:20 [main] INFO  n.r.c.e.ExternalPluginManager - Loading external plugin "bank-tag-layouts" version "1.4.13" commit "7086c205cfcd2f5c6eee37ec85b5f30a6ce58f1f"
2022-02-11 02:01:20 [main] INFO  n.r.c.e.ExternalPluginManager - Loading external plugin "shattered-relics-fragment-presets" version "1.3" commit "1437f00ef26b0e1e6d0a92f932f829d120a0eba9"
2022-02-11 02:01:20 [main] INFO  n.r.c.e.ExternalPluginManager - Loading external plugin "tob-mistake-tracker" version "2.2" commit "9dd1e66df1b4ebf8f540d69fa14075ff29a92147"
2022-02-11 02:01:20 [main] INFO  n.r.c.e.ExternalPluginManager - Loading external plugin "raid-data-tracker" version "1.4.2" commit "116be0bd660c8aca53c15c399c595f0156984455"
2022-02-11 02:01:20 [main] INFO  n.r.c.e.ExternalPluginManager - Loading external plugin "runedoku-helper" version "1.1" commit "abc69adc6f6e1309e045512b5cf3df0d78a93718"
2022-02-11 02:01:20 [main] INFO  n.r.c.e.ExternalPluginManager - Loading external plugin "raid-reloader" version "415a4b71" commit "415a4b71a6f94f9f10345f5c825ab1109bc7cb07"
2022-02-11 02:01:20 [main] INFO  n.r.c.e.ExternalPluginManager - Loading external plugin "pvp-performance-tracker" version "1.5.1" commit "6aeed770c8e4cfaf99c47e16b74281bf623d9179"
2022-02-11 02:01:20 [main] INFO  n.r.c.e.ExternalPluginManager - Loading external plugin "theatre-of-blood-stats" version "1.3" commit "9c4493305fb6e28e283d622c674779a007c19ea3"
2022-02-11 02:01:20 [main] INFO  n.r.c.e.ExternalPluginManager - Loading external plugin "quest-helper" version "2.8.3" commit "698ecbad965d91c9cfcc39d47cf982643c1290c7"
2022-02-11 02:01:20 [main] INFO  n.r.c.e.ExternalPluginManager - Loading external plugin "emote-clue-items" version "3.3.1" commit "e5a449e24c1c7567983e5348ae32743c9190052c"
2022-02-11 02:01:20 [main] INFO  n.r.c.e.ExternalPluginManager - Loading external plugin "tob-damage-counter" version "1.1" commit "bbfa095fd86b0ca3d80f678d14e1b7595e9556c8"
2022-02-11 02:01:20 [main] INFO  n.r.c.e.ExternalPluginManager - Loading external plugin "the-gauntlet" version "4e13d3eb" commit "4e13d3ebdf7da91f96c3a47856b2ac19de1e48c8"
2022-02-11 02:01:20 [main] INFO  n.r.c.e.ExternalPluginManager - Loading external plugin "wikisync" version "2.0" commit "8246ef597be7554010737e8c47559b23d689410f"
2022-02-11 02:01:20 [main] INFO  n.r.c.e.ExternalPluginManager - Loading external plugin "fashionscape" version "1.1.14" commit "9362e0d796c61e21323a4bd758fe197a67b62198"
2022-02-11 02:01:20 [main] INFO  n.r.c.e.ExternalPluginManager - Loading external plugin "supplies-tracker" version "2.01" commit "ec81a6706bac83dcffa82f80c157bc1a3e866df2"
2022-02-11 02:01:20 [main] INFO  n.r.c.e.ExternalPluginManager - Loading external plugin "crab-stun-timers" version "b0e7ad22" commit "b0e7ad22a6018fed3cdcd105d6a1873a242e75e3"
2022-02-11 02:01:20 [main] INFO  n.r.c.e.ExternalPluginManager - Loading external plugin "easyparty" version "1.0.1" commit "ae824f36fd034d2c178cdeb1a1870f1710161a94"
2022-02-11 02:01:20 [main] INFO  n.r.c.e.ExternalPluginManager - Loading external plugin "bot-detector" version "1.3.7.2" commit "4970a15d0ea5103378f11bb69e1204a8b1057b13"
2022-02-11 02:01:21 [main] INFO  n.r.client.discord.DiscordService - Initializing Discord RPC service.
2022-02-11 02:01:23 [main] INFO  net.runelite.client.RuneLite - Client initialization took 5434ms. Uptime: 6035ms
2022-02-11 02:01:23 [pool-2-thread-1] INFO  n.r.client.discord.DiscordService - Discord RPC service is ready with user XXXX.
2022-02-11 02:01:23 [AWT-EventQueue-0] INFO  net.runelite.client.ui.ClientUI - Showing frame net.runelite.client.ui.ContainableFrame[frame0,682,415,1034x682,layout=java.awt.BorderLayout,title=RuneLite,normal,defaultCloseOperation=DO_NOTHING_ON_CLOSE,rootPane=javax.swing.JRootPane[,0,0,1034x682,layout=org.pushingpixels.substance.internal.ui.SubstanceRootPaneUI$SubstanceRootLayout,alignmentX=0.0,alignmentY=0.0,border=org.pushingpixels.substance.internal.utils.border.SubstancePaneBorder@7b0099c8,flags=16777673,maximumSize=,minimumSize=,preferredSize=],rootPaneCheckingEnabled=true]
2022-02-11 02:01:23 [Client] INFO  n.r.client.plugins.gpu.GpuPlugin - Using device: NVIDIA GeForce RTX 2070 SUPER/PCIe/SSE2
2022-02-11 02:01:23 [Client] INFO  n.r.client.plugins.gpu.GpuPlugin - Using driver: 4.6.0 NVIDIA 510.47.03

launcher.log:

2022-02-11 02:01:16 [main] INFO  net.runelite.launcher.Launcher - RuneLite Launcher version 2.1.5
2022-02-11 02:01:16 [main] INFO  net.runelite.launcher.Launcher - Setting hardware acceleration to OFF
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of client-1.8.11.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of slf4j-api-1.7.25.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of logback-classic-1.2.9.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of logback-core-1.2.9.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of jopt-simple-5.0.1.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of guava-23.2-jre.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of guice-4.1.0-no_aop.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of javax.inject-1.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of aopalliance-1.0.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of gson-2.8.5.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of substance-8.0.02.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of trident-1.5.00.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of commons-text-1.2.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of commons-lang3-3.7.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of commons-csv-1.4.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of archive-patcher-1.0.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of jna-5.9.0.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of jna-platform-5.9.0.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of jsr305-3.0.2.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of jogl-all-2.4.0-rc-20200429.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of jogl-all-2.4.0-rc-20200429-natives-windows-amd64.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of jogl-all-2.4.0-rc-20200429-natives-windows-i586.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of jogl-all-2.4.0-rc-20200429-natives-linux-amd64.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of jogl-all-natives-macosx-2.4.0-rc-20210117.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of gluegen-rt-2.4.0-rc-20200429.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of gluegen-rt-2.4.0-rc-20200429-natives-windows-amd64.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of gluegen-rt-2.4.0-rc-20200429-natives-windows-i586.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of gluegen-rt-2.4.0-rc-20200429-natives-linux-amd64.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of gluegen-rt-natives-macosx-2.4.0-rc-20210117.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of jocl-1.0.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of jocl-1.0-macos-x64.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of jocl-1.0-macos-arm64.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of client-patch-1.8.11.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of http-api-1.0.0.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of okhttp-3.14.9.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of okio-1.17.2.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of discord-1.4.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.Launcher - Verified hash of runelite-api-1.8.11-runtime.jar
2022-02-11 02:01:17 [main] INFO  net.runelite.launcher.JvmLauncher - Running [/usr/lib/jvm/java-11-openjdk/bin/java, -cp, /home/XXXX/.runelite/repository2/client-1.8.11.jar:/home/XXXX/.runelite/repository2/slf4j-api-1.7.25.jar:/home/XXXX/.runelite/repository2/logback-classic-1.2.9.jar:/home/XXXX/.runelite/repository2/logback-core-1.2.9.jar:/home/XXXX/.runelite/repository2/jopt-simple-5.0.1.jar:/home/XXXX/.runelite/repository2/guava-23.2-jre.jar:/home/XXXX/.runelite/repository2/guice-4.1.0-no_aop.jar:/home/XXXX/.runelite/repository2/javax.inject-1.jar:/home/XXXX/.runelite/repository2/aopalliance-1.0.jar:/home/XXXX/.runelite/repository2/gson-2.8.5.jar:/home/XXXX/.runelite/repository2/substance-8.0.02.jar:/home/XXXX/.runelite/repository2/trident-1.5.00.jar:/home/XXXX/.runelite/repository2/commons-text-1.2.jar:/home/XXXX/.runelite/repository2/commons-lang3-3.7.jar:/home/XXXX/.runelite/repository2/commons-csv-1.4.jar:/home/XXXX/.runelite/repository2/archive-patcher-1.0.jar:/home/XXXX/.runelite/repository2/jna-5.9.0.jar:/home/XXXX/.runelite/repository2/jna-platform-5.9.0.jar:/home/XXXX/.runelite/repository2/jsr305-3.0.2.jar:/home/XXXX/.runelite/repository2/jogl-all-2.4.0-rc-20200429.jar:/home/XXXX/.runelite/repository2/jogl-all-2.4.0-rc-20200429-natives-windows-amd64.jar:/home/XXXX/.runelite/repository2/jogl-all-2.4.0-rc-20200429-natives-windows-i586.jar:/home/XXXX/.runelite/repository2/jogl-all-2.4.0-rc-20200429-natives-linux-amd64.jar:/home/XXXX/.runelite/repository2/jogl-all-natives-macosx-2.4.0-rc-20210117.jar:/home/XXXX/.runelite/repository2/gluegen-rt-2.4.0-rc-20200429.jar:/home/XXXX/.runelite/repository2/gluegen-rt-2.4.0-rc-20200429-natives-windows-amd64.jar:/home/XXXX/.runelite/repository2/gluegen-rt-2.4.0-rc-20200429-natives-windows-i586.jar:/home/XXXX/.runelite/repository2/gluegen-rt-2.4.0-rc-20200429-natives-linux-amd64.jar:/home/XXXX/.runelite/repository2/gluegen-rt-natives-macosx-2.4.0-rc-20210117.jar:/home/XXXX/.runelite/repository2/jocl-1.0.jar:/home/XXXX/.runelite/repository2/jocl-1.0-macos-x64.jar:/home/XXXX/.runelite/repository2/jocl-1.0-macos-arm64.jar:/home/XXXX/.runelite/repository2/client-patch-1.8.11.jar:/home/XXXX/.runelite/repository2/http-api-1.0.0.jar:/home/XXXX/.runelite/repository2/okhttp-3.14.9.jar:/home/XXXX/.runelite/repository2/okio-1.17.2.jar:/home/XXXX/.runelite/repository2/discord-1.4.jar:/home/XXXX/.runelite/repository2/runelite-api-1.8.11-runtime.jar, -XX:+DisableAttachMechanism, -Xmx512m, -Xss2m, -XX:CompileThreshold=1500, -Djna.nosys=true, -Dsun.java2d.noddraw=true, -Dsun.java2d.opengl=false, -Djava.net.preferIPv4Stack=true, -Djava.net.preferIPv4Addresses=true, -Drunelite.launcher.version=2.1.5, -XX:ErrorFile=/home/XXXX/.runelite/logs/jvm_crash_pid_%p.log, net.runelite.client.RuneLite]

RuneLite Window settings: 2022-02-11_02-06

Septem151 commented 2 years ago

xprop output for window:

_NET_WM_DESKTOP(CARDINAL) = 0
awful.client.property.floating(CARDINAL) = 1
_NET_FRAME_EXTENTS(CARDINAL) = 2, 2, 2, 2
WM_STATE(WM_STATE):
        window state: Normal
        icon window: 0x0
awful.client.property.single_instance_id(UTF8_STRING) =
_NET_WM_WINDOW_TYPE(ATOM) = _NET_WM_WINDOW_TYPE_NORMAL
_MOTIF_DRAG_RECEIVER_INFO(_MOTIF_DRAG_RECEIVER_INFO) = 0x6c, 0x0, 0x5, 0x0, 0x2c, 0x0, 0xa0, 0x4, 0x0, 0x0, 0x0, 0x0, 0x10, 0x0, 0x0, 0x0
XdndAware(ATOM) = BITMAP
_NET_WM_STATE(ATOM) =
WM_HINTS(WM_HINTS):
        Client accepts input or input focus: False
        Initial state is Normal State.
_OL_DECOR_DEL(ATOM) = _OL_DECOR_HEADER, _OL_DECOR_RESIZE, _OL_DECOR_CLOSE
_MOTIF_WM_HINTS(_MOTIF_WM_HINTS) = 0x3, 0x2c, 0x0, 0x0, 0x0
_NET_WM_ICON(CARDINAL) =    Icon (128 x 128):
    (not shown)

_NET_WM_PID(CARDINAL) = 32987
WM_CLIENT_MACHINE(STRING) = "XXXX"
WM_PROTOCOLS(ATOM): protocols  WM_DELETE_WINDOW, WM_TAKE_FOCUS
WM_CLASS(STRING) = "net-runelite-client-RuneLite", "net-runelite-client-RuneLite"
WM_CLIENT_LEADER(WINDOW): window id # 0x4a00008
_NET_WM_ICON_NAME(UTF8_STRING) = "RuneLite"
WM_ICON_NAME(STRING) = "RuneLite"
_NET_WM_NAME(UTF8_STRING) = "RuneLite"
WM_NAME(STRING) = "RuneLite"
WM_NORMAL_HINTS(WM_SIZE_HINTS):
        user specified location: 1082, 406
        program specified location: 1082, 406
        program specified size: 1276 by 682
        program specified minimum size: 1276 by 682
        program specified maximum size: 2560 by 1440
        window gravity: NorthWest
Septem151 commented 2 years ago

Only happens when the window itself is resized, maybe having something to do with Java's awt being the culprit. When the setting for "Resize type" is set to "Keep window size", the window position does not change.

abextm commented 2 years ago

duplicate #2561