search

runelite / runelite

Open source Old School RuneScape client
https://runelite.net
BSD 2-Clause "Simplified" License
4.82k stars 5.25k forks source link

[Bank Tags] Auto layout automatically creates placeholders for untagged items in inventory/equipment #18502

Open fuzxi opened 2 weeks ago

fuzxi commented 2 weeks ago

Type

Incorrect behavior

Operating System

None

OS Version

No response

Bug description

Create a tag tab. Add at least one item to it. Equip or withdraw a different item. Open the tag tab. Right-click the tag tab and use either auto layout option. Expected behavior is for the items in the selected tag tab to be automatically laid out. Actual behavior is that items in the selected tag tab, as well as all items equipped and in the inventory, are automatically laid out. Items which were not in the tag tab are not assigned the tag, and disabling layout mode will delete them from the tag entirely.

Screenshots or videos

https://github.com/user-attachments/assets/47f065f4-e95a-484b-a3c5-38b765f6e94e

RuneLite version

RuneLite version: 1.10.43 Launcher version. 2.6.10

Logs

No response

geheur commented 2 weeks ago

I think you are just noticing differences in hub vs core layouts. disabling layout deletes it in core layouts. also, jagex placeholders don't show in core layouts.

fuzxi commented 2 weeks ago

Not really sure what you mean - this is with core layouts. I do not have Bank Tag Layouts from the plugin hub installed.

geheur commented 2 weeks ago

well everything in your video is working as intended. so there is no bug afaict. Actually on second thought, I'm not sure if it's correct.

fuzxi commented 2 weeks ago

Why is the intended behavior to add untagged items to the layout? If the player wants to add items to the tag, they can right-click the deposit inventory/equipment buttons to quickly tag them all, then apply the automatic layout.

geheur commented 2 weeks ago

Where do you expect the battlestaff in the tab to go? What position is it supposed to lay it out to? I don't think you understand what this feature is. Your video shows the intended behavior, minus the fact that the tagged items were removed when you disabled the layout. that part seems weird.

fuzxi commented 2 weeks ago

Using auto layout should have done nothing, the battlestaff should have just stayed where it was.

minus the fact that the tagged items were removed

This is the issue. Those items aren't tagged at all! They had no tags both before and after using the auto layout, which is why disabling layout mode removed them from the tab.