runelite / runelite

Open source Old School RuneScape client
https://runelite.net
BSD 2-Clause "Simplified" License
4.76k stars 5.21k forks source link

Stretched Fixed Mode - Integer Scaling Issue #4504

Open kivztg opened 6 years ago

kivztg commented 6 years ago

Screen flickering and constant resizing when enabling integer scaling on stretched fixed mode, with the keep aspect ratio option enabled. Integer scaling on its own is producing an image half the normal size. Keep aspect ratio without integer scaling works correctly. Issue unaffected by hardware acceleration.

Screen recording: https://youtu.be/3evA-Thx3x4

Runelite version 1.4.8.1 Windows 10 Home 64-bit Intel Graphics HD 500 (Celeron N3450)

logs.zip

deathbeam commented 6 years ago

Hmm this is interesting, so the screen just stays in that weird corrupted mode after turning on integer scaling?

kivztg commented 6 years ago

Okay, I've just learned something I forgot to mention I was working with. I followed guides to disable windows scaling for specific applications, the settings I attempted did not remedy this, but did affect the UI so I assumed that windows scaling was not a factor. However, I just disabled windows scaling altogether and integer scaling is working properly now. Disabling the compatibility settings I tried, with windows scaling on yielded different results, it simply doesn't attempt the stretching at all while integer scaling and keep aspect ratio are enabled. I hope this helps

robmonte commented 6 years ago

Runelite V1.4.9.1 OSX 10.13.6

@deathbeam An issue with integer scaling for me also, the option is no longer working as expected. It is keeping the game at its default size instead of resizing it now but it was working a few weeks ago on the same computer.

raku-cat commented 5 years ago

I get a similar issue on linux. On my 1600x900 monitor it loops trying to resize, if i open a side menu it stops and just goes to the default small size, turning off keep aspect ratio causes the game to be very short(height) but stretched along the screen, moving the window to my 1920x1080 monitor causes the game to resize to 2x and cause no issues.

Nightfirecat commented 4 years ago

Is this still an issue? The video in the original issue report has gone missing, and I have not heard of this issue being reported since the last post.

robmonte commented 4 years ago

@Nightfirecat Yes, Integer Scaling is still broken and non-functional on MacOS. The Stretched Mode plugin as a whole seems to at least work in some regard now, such as properly fitting the game into the window (it still randomly will glitch sometimes though it usually goes away after toggling off/on).

However, Integer Scaling itself seems to now do nothing at all. Turning on this setting does nothing for performance. I would say this is a pretty significant feature to be broken on MacOS due to the fact that Apple's machines tend to have very high resolution displays. The game absolutely chugs dropping to sub-20 FPS when idling. This is on a 2018 15" Macbook Pro.

Nightfirecat commented 4 years ago

What is your screen resolution? Integer scaling requires a pretty significant vertical resolution to have any effect as most people using it do not have large enough displays to reach even 2x size.

robmonte commented 4 years ago

@Nightfirecat 2880x1800. There is definitely enough room for 4x game windows. You can find past issues where I've documented the same occurrences so you can see I'm consistent. https://github.com/runelite/runelite/issues/6022 and https://github.com/runelite/runelite/issues/6490

 

Here are new screenshots taken today. The first is untouched with the stretched plugin OFF:

image

 

Here is me showing there's ample room available for a 2x integer scale to apply:

image

 

If you look at the second issue I mentioned, the warped stretching is no longer occurring (what I was referencing in my previous comment about working in some regard). However, it's clear that the game even now is still trying to render at full resolution regardless of integer scaling being checked or not. The login screen gives me like 5 FPS.