runem / lit-analyzer

Monorepository for tools that analyze lit-html templates
MIT License
318 stars 36 forks source link

Fix location where imports are inserted. #111

Closed FelixSchuSi closed 4 years ago

FelixSchuSi commented 4 years ago

When using the codefix suggested by the "no-missing-import" rule, the import statement currently gets inserted on line one. In some cases it even overwrites existing import statements.

This is likely a mistake from the refactoring that was done on the 1.2.0 branch. This code was wrongly refactored into this.

Notice how the setting changed from span to range but the parameters stayed the same.

runem commented 4 years ago

Great catch, thank you for contributing! :blush: