runem / lit-analyzer

Monorepository for tools that analyze lit-html templates
MIT License
319 stars 38 forks source link

[lit-plugin] With 1.2.0 version autocomplete in CSS is broken #120

Closed herberthobregon closed 4 years ago

herberthobregon commented 4 years ago

In this new version the autocomplete does not work correctly, I had to go back to version 1.1.10 in vscode.

If I try to put an example like

div {
    disp...
}

It doesn't autocomplete, image

while in version 1.1.10 if it works correctly image

Many other css properties don't autocomplete correctly.

I checked it on the vscode of 3 other colleagues and the exact same thing happens.

Thanks for your amazing work! If I can help you, don't hesitate to tell me

runem commented 4 years ago

I'm so sorry for the regression! I tested it extensively, but I think this slipped because I always force autocompletions with "ctlr + space" in the middle of some text, and this worked under most circumstances. However, it rarely worked if the autocompletion wasn't forced to set in.

I just uploaded a .vsix which you can download here. It would be very helpful to me if you want to test if the problem has been fixed for you, and that it behaves as expected, You can install it like this:

Screenshot 2020-07-20 at 19 47 11
herberthobregon commented 4 years ago

I'm still having the same problem, the CSS still doesn't auto-complete correctly :(

image

It works if I force autocomplete before starting to write, but as you mentioned it no longer autocompletes correctly when you have written something and then autocomplete

runem commented 4 years ago

This is what I see when testing autocompletion. In this video I don't force auto completion at any point:

autocompletion

I have a couple of things you can try if you have the time :-)

herberthobregon commented 4 years ago

It has worked! Thank you! Completely closing VScode after installing (⌘ + Q) has successfully loaded the update sent to me by Google Drive!

runem commented 4 years ago

Great, I'm happy to hear that! I will publish the fix to the marketplace within a couple of days :-)