aria-haspopup no-incompatible-type-binding false alarm

runem / lit-analyzer

Monorepository for tools that analyze lit-html templates

MIT License

319 stars 38 forks source link

aria-haspopup no-incompatible-type-binding false alarm #142

Open pmcelhaney opened 4 years ago

pmcelhaney commented 4 years ago

The following code triggers Type '"listbox"' is not assignable to '"true" | "false"'lit-plugin(no-incompatible-type-binding)(2304).

<button aria-haspopup="listbox"></button>

That's not accurate. aria-haspopup can several values other than "true" or "false".

https://www.w3.org/TR/wai-aria/#aria-haspopup

I did a quick scan through the code and it looks like the bug may be in an upstream dependency. If someone can point me in the right direction I'll open a PR.

bradniksa commented 3 years ago

I second this issue, I am getting the same error.

Screen Shot 2021-03-26 at 9 59 18 AM

joekukish commented 3 years ago

I've made a PR for this: https://github.com/runem/lit-analyzer/pull/175

brentswisher commented 11 months ago

@rictic just a heads up I am pretty sure release v2.0.1 fixed this issue and it and #175 can both be closed now.