runem / lit-analyzer

Monorepository for tools that analyze lit-html templates
MIT License
318 stars 36 forks source link

how can i get v1.2.4 with the auto-import fix? #263

Open chase-moskal opened 2 years ago

chase-moskal commented 2 years ago

:wave: hello fine folks, i'm glad to see that this project is being maintained!

the auto-import bug has been a thorn in my team's side -- we're confused about how to obtain the fabled fix for this bug

it looks like the bug has been fixed, and it's been said that the fix has been released :thinking:

however, i don't seem to see this release anywhere? am i looking in the wrong places?

we're just very eager to get this fix!

is v1.2.4 with the fix under some different package/extension name? or perhaps there has been some mistake where this version failed to be published? maybe i'm just confused, and it hasn't been released yet?

we're even willing to follow some back-alley shell-scripted instructions, if it helps us install the development copy necessary to get this fix ;)

thanks friends for any help :beers:

justinfagnani commented 2 years ago

My VS Code installation just automatically updated. I don't know what open-vsx is, but the Visual Studio Marketplace where we publish to shows v1.2.4: https://marketplace.visualstudio.com/items?itemName=runem.lit-plugin

One thing I notice is that in my VS Code I see > 40k downloads, while yours shows just 1.1k. Something seems up there.

What happens if you uninstall and reinstall the extension?

justinfagnani commented 2 years ago

Ok, looks like from here that @runem had published this to open-vsx at some point and we need to resume doing that: https://github.com/runem/lit-analyzer/issues/151 We didn't get permissions to publish there yet like we did with Visual Studio Maketplace so we'll need to work that out with @runem and it could take a bit. cc @rictic

@chase-moskal can you install from the Visual Studio Maketplace in the mean time?

chase-moskal commented 2 years ago

ahah! thanks so much @justinfagnani, now i understand what's going on!

unbeknownst to me, here on manjaro linux, i was actually running a non-microsoft oss distribution of vscode — the official archlinux code package — this package has modified extensions support by using the open-vsx extensions registry (instead of the official visual studio marketplace)

as it turns out, many of the open-vsx extensions are out of date by comparison with the visual studio marketplace.

i solved this issue by

i hadn't realized my vscode was using an alternative extensions registry (it's well-integrated in the oss distribution), and of course seeing the npm package being outdated had also confused me.

of course, i'm sure it would be nice if the deployment routine for lit-plugin included publishing to the open-vsx registry also — but this problem is solved from my perspective, so feel free to close this issue.

thanks again! :beers: