search

runem / lit-analyzer

Monorepository for tools that analyze lit-html templates
MIT License
317 stars 36 forks source link

Update web-component-analyzer dependency to fix ts5.x support #305

Closed 43081j closed 1 year ago

43081j commented 1 year ago

this should fix the various problems people are having

cc @rictic

FYI i couldn't write an extra test that fails before this change as i'd need to change the repo's typescript to 5.x, and that breaks the build thanks to a mismatch of types

we could just publish a prerelease and test it manually

let me know what you think

rictic commented 1 year ago

Weird that the vscode downloader fails on windows with Node >16, but this modernizes the rest of the tests' node versions

artemyarulin commented 1 year ago

Thanks for your PR - can confirm that using "lit-analyzer": "^2.0.0-pre.3", fixes problem with running lit-analyzer as a command line utility. Unfortunately TypeScript plugin and VS code extension doesn't work still, but I assume it will be fixed later.

Thanks you!

43081j commented 1 year ago

yup we still need to publish the new version of the vscode extension, so that will still have the problems i think for now

but peter is looking into it so should be up soon

great to know the CLI part works though 🙏

rictic commented 1 year ago

Sorry it took a bit of extra time, but the VSCode extension has now been released!

On Fri, Jun 16, 2023, 4:18 AM James Garbutt @.***> wrote:

yup we still need to publish the new version of the vscode extension, so that will still have the problems i think for now

but peter is looking into it so should be up soon

great to know the CLI part works though 🙏

— Reply to this email directly, view it on GitHub https://github.com/runem/lit-analyzer/pull/305#issuecomment-1594519010, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAM65J2QIVVITIG7O4ZOLXLQ6GRANCNFSM6AAAAAAZE4UQQM . You are receiving this because you modified the open/close state.Message ID: @.***>