search

runem / lit-analyzer

Monorepository for tools that analyze lit-html templates
MIT License
314 stars 35 forks source link

Adds integration test for no-missing-import #335

Closed benjamind closed 6 months ago

benjamind commented 7 months ago

This adds an integration test for the vscode plugin to demonstrate the failure case for no-missing-import.

It loads a file with a missing import, and then adds the line into the editor for the import. This should fix all errors in the file, but instead we see a diagnostic for the other element in the page. It seems the extension is only resolving one import at a time.

This could be (and most likely is) a bug in lit-analyzer package itself, but only manifests in the extension where our TS state is dynamic. I'm guessing its a caching issue?

AndrewJakubowicz commented 6 months ago

Thank you so much for your test. It was included in https://github.com/runem/lit-analyzer/pull/338 with the fix.