search

runem / lit-analyzer

Monorepository for tools that analyze lit-html templates
MIT License
319 stars 38 forks source link

Allow to disable rules in strict mode #81

Closed hanc2006 closed 4 years ago

hanc2006 commented 4 years ago

Hi, currently if I use the "strict" mode and I want to disable a specific rule, this automatically disables the "strict" mode.

Example: "lit-plugin.strict": true, "lit-plugin.rules.no-complex-attribute-binding": "off",

Expected result: All "strict" rules active, without the disabled rule above.

Current result: Strict mode is disabled.

This behavior does not happen if instead I put the rule notification in "warning"

runem commented 4 years ago

Thanks for reporting this issue, I'm sorry for the late answer!

I've been making a lot of changes on this PR: https://github.com/runem/lit-analyzer/pull/112 and I can't reproduce your problem in that PR. Therefore I expect this issue to be fixed and I will close it when the PR has been released and merged into master.

Feel free to test out the beta version of the plugin by downloading and installing this .vsix file: https://github.com/runem/lit-analyzer/suites/892943037/artifacts/10623637 in order to test if you can reproduce the issue :-)