runem / lit-analyzer

Monorepository for tools that analyze lit-html templates
MIT License
318 stars 36 forks source link

no-legacy-attribute rule #95

Closed 43081j closed 4 years ago

43081j commented 4 years ago

could this be a solution to #92 in a way?

i haven't added docs and finished it up just in case its not the kind of solution we're looking for.

it just detects legacy polymer binding syntax (foo$=, foo?=, foo="[[bar]]", foo="{{bar}}).

cc @rictic @runem

runem commented 4 years ago

This looks great, thanks for the contribution! I will merge as soon as the rule is described in the readme :+1:

The description of the rule would have to be added to docs/readme/rules.md. You don't have to run npm run readme, because it seems like the formatting of packages/*/README.md is out of sync. I'll take a look at fixing that after the merge :-)

rictic commented 4 years ago

This is really great!

43081j commented 4 years ago

here you go i rebased on master and updated docs

runem commented 4 years ago

Fantastic, thanks! ☀️ I'll merge now :-)