Closed 43081j closed 3 years ago
no clue why that test fails in CI... if i re-introduce the extra spaces, it fails locally 🤔
edit: seems to build in ci at least with the spaces added back, seems like a potentially flaky test
@43081j Anything we can do to help move this along? This is the only blocker from our project upgrading to 4.3
i think we need @justinfagnani to review it and merge, its likely hes pretty busy with lit stuff right now though.
im happy with the change i think otherwise, seems to work well but could do with one thorough review
Fixes #214
This upgrades a bunch of dependencies:
.editorconfig
- it looks like rune used tabs in most places so i went with that@rollup/*
)Added a test using
override
syntax too to ensure the syntax works.cc @rictic @justinfagnani