dns-loopia - Githubissues

runfalk / certbot-dns-loopia

Loopia DNS authentication plugin for Certbot

Other

37 stars 11 forks source link

dns-loopia #11

Closed kmpm closed 3 years ago

kmpm commented 3 years ago

Closes #10

change name
added tests
defaults as constants
dropped propagation time to 90 second (tested several times with success)

kmpm commented 3 years ago

You might want to rename the repo and update documentation + setup.py but that is up to you to decide.

kmpm commented 3 years ago

Oh.. Closes #9 as well

runfalk commented 3 years ago

Thank you for updating the PR. I think this looks good for merging. I'll keep this open until I have time to update the package on PyPI as well as tagging the new release. If I haven't merged this by Sunday, please bug me here again.

Squachen commented 3 years ago

Can confirm that this PR works. Just created a wildcard certificate using it.

sterys commented 3 years ago

If I haven't merged this by Sunday, please bug me here again.

I thinkt a Sunday has passed so I do bug you :-)

kmpm commented 3 years ago

bugging you :)

kmpm commented 3 years ago

and if you want help with pypi, then I can do that as well, just let me.

runfalk commented 3 years ago

So I have released everything. Thanks a lot for your contribution @kmpm!

Sorry it took me so long.