search

runfalk / certbot-dns-loopia

Loopia DNS authentication plugin for Certbot
Other
36 stars 11 forks source link

Added a GHA workflow that runs pylint #16

Closed MrRawbin closed 2 years ago

MrRawbin commented 2 years ago

After this commit, pylint runs in GitHub Actions on every push, using default pylint config (for now).

Also fixed all the minor issues that pylint complained about.

runfalk commented 2 years ago

Thanks Robin! Overall I think this looks pretty good. I'll leave the final word to @kmpm

kmpm commented 2 years ago

Running a linter is a really good thing and apart from not getting why a script is needed when pylint probably just as well could be executed from the action it looks really good. And I don't mind keeping multiple python versions for when automatic testing could be implemented, but do as you like.

kmpm commented 2 years ago

Tack!