feat: Add support for nerdctl config and default variables

runfinch / finch-daemon

Apache License 2.0

7 stars 10 forks source link

feat: Add support for nerdctl config and default variables #73

Closed Shubhranshu153 closed 3 weeks ago

Shubhranshu153 commented 3 weeks ago

Issue #, if available:

Description of changes: This feature adds capability to read configurations from nerdctl toml file and nerdctl supported env variables and configure accordingly.

Testing done: Functional test are added for functions to check logical and functional correctness.

[x] I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Shubhranshu153 commented 3 weeks ago

While the implementation looks good, I have a general comment:

Why are we using nerdctl environment variables, and naming the config after nerdctl, when we can add these to a finch or finch-daemon specific config file?

We can move to /etc/finch/finch-daemon.toml (it need not be called nerdctl just wanted the same behaviour where we are able to set namespace and other configs for the daemon)