feat: add distribution API - Githubissues

runfinch / finch-daemon

Apache License 2.0

7 stars 10 forks source link

feat: add distribution API #92

Closed pendo324 closed 1 week ago

pendo324 commented 2 weeks ago

Issue #, if available:

Description of changes

Adds the Distribution API, as documented here https://docs.docker.com/reference/api/engine/version/v1.43/#tag/Distribution
Refactored some code out of the Image service as it was useful for the new Distribution service as well
Regenerating mocks caused minor diffs in 2 existing files (reordering/adding whitespace)

Testing done

Unit tests for new API handler (76%) and service (85%)
Manual testing using docker-py, and comparison to other implementations

Contribution agreement

[x] I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Shubhranshu153 commented 2 weeks ago

nit: Requesting change heading to Image Distribution API (Distribution API in itself is a thing)

Shubhranshu153 commented 2 weeks ago

LGTM: Should we contribute it to nerdctl long term?