runfinch / finch-daemon

Apache License 2.0
7 stars 10 forks source link

refactor: Update to nerdctl and containerd v2.0.0 #98

Closed sondavidb closed 1 week ago

sondavidb commented 1 week ago

Issue #, if available:

Description of changes:

Updated libraries to use containerd 2.0 and nerdctl 2.0. This includes some functionality changes on nerdctl's end so I had to do some code changes to keep as similar behavior as possible.

FUNCIONALITY CHANGES:

The first two commits should only include imports and package name changes and no real code functionality changes. The third commit should have all of the functionality changes (as well a couple of package name changes that I missed + changes I needed after rebasing, sorry 😔)

Testing done: make test-unit && make test-e2e

Worth noting that I had one test failure on my machine related to namespace overlap due to Docker using the same namespace, I tried changing the namespace but had some issues so I'll first see how the CI handles it before seeing what changes have to be made

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sondavidb commented 1 week ago

Given the backwards-incompatible nature of this change we will hold off on this until containerd announces their next LTS version