runfinch / finch

The Finch CLI is an open source client for container development
https://www.runfinch.com
Apache License 2.0
3.51k stars 90 forks source link

ci: Nightly build failing SOCI tests #532

Closed ginglis13 closed 1 year ago

ginglis13 commented 1 year ago

Describe the bug

test for SOCI integration use limactl to shell into the VM to verify that container fs mounts match the expected behavior when using the SOCI snapshotter:

https://github.com/runfinch/finch/blob/c97d2e93edaf139c3960620ec00454f856a8daee/e2e/vm/soci_test.go#L29-L36

tests are failing as:

 fork/exec /Users/ec2-user/ar/_work/finch/finch/_output/lima/bin/limactl: no such file or directory

We probably need to change the logic of the test for finding the limatcl executable, since the tests for this workflow are using INSTALLED=true, we are not using the limatcl built in _output

https://github.com/runfinch/finch/blob/c97d2e93edaf139c3960620ec00454f856a8daee/.github/workflows/build-and-test-pkg.yaml#L220

Steps to reproduce

https://github.com/runfinch/finch/actions/workflows/build-and-test-pkg.yaml

Expected behavior

using the right limactl, green CI

Screenshots or logs

Additional context