search

runfinch / finch

The Finch CLI is an open source client for container development
https://www.runfinch.com
Apache License 2.0
3.51k stars 90 forks source link

Resolve ShellCheck lint warnings #550

Closed austinvazquez closed 7 months ago

austinvazquez commented 1 year ago

What is the problem you're trying to solve?. https://github.com/runfinch/finch/pull/458 added ShellCheck to Finch CI for linting Finch shell scripts. The step is currently non-critical due to some lingering non-trivial lint warnings.

Describe the feature you'd like It would be nice to resolve the remaining warnings and make the CI step critical.

Additional context N/A

RiverPhillips commented 11 months ago

I'd like to look into this

mharwani commented 7 months ago

Issue is fixed. Closing.