runfinch / finch

The Finch CLI is an open source client for container development
https://www.runfinch.com
Apache License 2.0
3.51k stars 90 forks source link

ci: Make unsigned MSI has timestamp in its name to easily unique fetch it back #636

Closed KevinLiAWS closed 11 months ago

KevinLiAWS commented 11 months ago

Description of changes: When uploading the unsigned to S3, the signer will assign a random postfix to the original MSI. However, since 0.0.0 is a common test install name, it is hard to uniquely identify the signed MSI since there can be historical ones. Added timestamp in the name so that it can be easily fetched back.

Testing done: Tested with this action run: https://github.com/runfinch/finch/actions/runs/6503614023/job/17664348385

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.