fix: improve creds helper UX - Githubissues

runfinch / finch

The Finch CLI is an open source client for container development

https://www.runfinch.com

Apache License 2.0

3.51k stars 90 forks source link

fix: improve creds helper UX #673

Closed pendo324 closed 11 months ago

pendo324 commented 11 months ago

Issue #, if available:

Description of changes:

Make it so aws configure is also run on the run command, since that may invoke a pull
Clean up code and consider config.json's state when checking if the cred helper is "installed" or not
TODO: remove need for var overriding to facilitate testing

Testing done:

local testing, e2e tests
[x] I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.